-
-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
autocomplete milestone #526
Conversation
…utocomplete_refactor milestone
@@ -82,6 +82,10 @@ module.exports = _.merge({}, peliasQuery.defaults, { | |||
'admin:neighbourhood:field': 'parent.neighbourhood', | |||
'admin:neighbourhood:boost': 200, | |||
|
|||
'admin:borough:analyzer': 'peliasAdmin', | |||
'admin:borough:field': 'parent.borough', | |||
'admin:borough:boost': 800, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why so high?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I simply copied the value from 'country', I will drop it down to a value for 'region' instead if you feel it's too high. What would you suggest as a good value here?
We noticed a regression from pelias/pelias#164. When searching for "New York, NY" from Stamford, CT, autocomplete for "New York, NY" used to show the city of NYC first, now it doesn't There's now an acceptance test for this: pelias/acceptance-tests#232 |
…efactor improve api-side tokenizer
👍 |
This PR contains all the work that's gone in to the Autocomplete Improvements Milestone, it is paired with a corresponding schema update.
The PR is focused around fixing bugs and flaky behavior in
/v1/autocomplete
that's been reported by our users, I've also taken the opportunity to triage all the incoming requests for autocomplete, clean up some messy parts and add more code coverage.The major difference in behavior is due to how we handle analysis and especially synonym substitution for autocomplete, an example of a query which was not previously possible using phrase matching:
improved analysis
more information about the analysis changes can be found in: pelias/schema#105
final token is a stopword bug
This reported bug has been squashed: pelias/pelias#211
improved server-side tokenizer
Improved parsing of source data containing commas or slashes as delimiters, such as in
Bedell Street/133rd Avenue
. see: pelias/schema#113improved client-side tokenizer
In order to generated the best/most efficient queries possible, we've added a client-size tokenizer which mimics the functionality of the server-side tokenizer. see: #529
improved handling of ordinals
This allows users to partially type an address such as "33rd street" as "33r", see pelias/schema#96
improved admin matching, particularly for non-delimited queries
this PR also includes a fix for
parent.borough
not being targeted during admin patching. see #527indexing of single digit numbers
in the past we did not index single digit numbers, they are now present in the index without causing a major increase in disk/ram usage.
tighter 'focus' clustering and improved localized matching
see: http://missinglink.embed.s3.amazonaws.com/pelias_clustering.png
house number can be provided in 1,2 or 3rd position
mainly for for Germanic addresses schemes. see #489
boosting of exact matches
an additional query segment was added to ensure that outputs that more closely match the input text appear higher than those which only partially match.